Remove newlines from tokens #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug in Phiki, discovered by comparing token generation with
vscode-textmate.Phiki was including the
\ncharacter inside of tokens, which it shouldn't be doing since TextMate grammars are evaluated on a per-line basis. The\ncharacter is only included in the subject text to ensure rules that check for a\noperate correctly (the same thing can be seen in the vscode-textmate codebase).This is technically a breaking change for users who are consuming tokens with the
codeToTokensmethod – users using the CommonMark plugin or the defaultHtmlGenerator/TerminalGeneratorwon't notice any changes as the appropriate updates have been made there.